Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parts of one click to direct message #7608

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

rodrigok
Copy link
Member

@RocketChat/core

Closes #7436

@rodrigok rodrigok added this to the 0.58.0 milestone Jul 31, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7608 July 31, 2017 13:07 Inactive
@sampaiodiego sampaiodiego changed the title Add mssing parts of one click to direct message Add missing parts of one click to direct message Jul 31, 2017
@rodrigok rodrigok merged commit dd77b12 into develop Aug 1, 2017
@rodrigok rodrigok deleted the improvements/one-click-to-direct-message branch August 1, 2017 00:09
@danieljhochman
Copy link

@rodrigok - this look great now. However, this feature introduced a new bug. If the feature is enabled, and I click on my own username, I get an "Invalid User" error.

Slack and HipChat both allow you to message yourself, so if that's easy to enable it does have use-cases (e.g. test how an emoji works). If that's a big deal to change perhaps just suppress the error for now. I'm sure there are other solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an option to go straight to direct message when clicking on a user's name
4 participants